Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add setup files #23

Merged
merged 4 commits into from
Sep 22, 2021
Merged

feat: add setup files #23

merged 4 commits into from
Sep 22, 2021

Conversation

bhavikapanara
Copy link
Contributor

No description provided.

@commit-lint
Copy link

commit-lint bot commented Sep 8, 2021

Contributors

bhavikapanara

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@codecov
Copy link

codecov bot commented Sep 8, 2021 •
edited
Loading

Codecov Report

Merging #23 (80234a7) into main (8a053b9) will increase coverage by 3.22%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
+ Coverage   89.06%   92.29%   +3.22%     
==========================================
  Files          10       14       +4     
  Lines         869     1272     +403     
==========================================
+ Hits          774     1174     +400     
- Misses         95       98       +3
Impacted Files Coverage Δ
src/pipeline/pose_engine.py 65.65% <0.00%> (-23.41%) ⬇️
src/pipeline/inference.py 88.00% <0.00%> (-0.24%) ⬇️
fall_prediction.py 100.00% <0.00%> (ø)
tests/pipeline/test_fall_detect.py
src/pipeline/pose_base.py 91.83% <0.00%> (ø)
src/pipeline/movenet_model.py 97.05% <0.00%> (ø)
tests/pipeline/test_fall_detect_posenet.py 100.00% <0.00%> (ø)
tests/pipeline/test_fall_detect_movenet.py 100.00% <0.00%> (ø)
src/pipeline/posenet_model.py 100.00% <0.00%> (ø)
src/pipeline/fall_detect.py 98.62% <0.00%> (+10.09%) ⬆️

@ivelin
Copy link

ivelin commented Sep 8, 2021

@bhavikapanara you only added setup.cfg which is not enough to publish a package. You also need setup.py. See how we do this for peerjs-python.

@ivelin
Copy link

ivelin commented Sep 8, 2021 •
edited
Loading

Look closer at the peerjs-python CI scripts for packaging and publishing a pypi package.

The three key scripts you need to study and understand are:

  1. https://github.com/ambianic/peerjs-python/blob/master/.github/workflows/pythonpackage.yml
  2. https://github.com/ambianic/peerjs-python/blob/master/build/prepare-release.sh
  3. https://github.com/ambianic/peerjs-python/blob/master/.github/workflows/pythonpublish.yml

pythonpackage.yml uses semantic release to analyze commits, prepare changelog and decide how to version the next release.
prepare-release.sh creates a local python package
pythonpublish.yml pushes the local package to the pypi package repo.

While testing your local scripts and CI runs, make sure to use TestPyPi to publish your new package from the CI workflow instead of the official PyPi repo.

@ivelin ivelin marked this pull request as draft September 8, 2021 18:15
@bhavikapanara
add setup files
04ebd8a 
Signed-off-by: bhavikapanara <[email protected]>
@bhavikapanara
update files
a726191 
Signed-off-by: bhavikapanara <[email protected]>
@bhavikapanara
update files
4bd9ade 
Signed-off-by: bhavikapanara <[email protected]>
@bhavikapanara
update file
80234a7 
Signed-off-by: bhavikapanara <[email protected]>
ivelin
ivelin approved these changes Sep 22, 2021
View reviewed changes
src/setup.cfg Outdated
@@ -1,7 +1,7 @@
[metadata]
name = ambianic-fall-detection
version = 1.0.0
author = Bhavika Panara
author = Ivelin Ivanov
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bhavikapanara you should leave your name as the author.

@ivelin ivelin marked this pull request as ready for review September 22, 2021 15:26
@ivelin ivelin merged commit 41ee60d into ambianic:main Sep 22, 2021
github-actions bot pushed a commit that referenced this pull request Oct 3, 2021
@semantic-release-bot
chore(release): 1.0.0 [skip ci]
3ac2d07 
# 1.0.0 (2021-10-03)

### Bug Fixes

* python setup files ([#23](#23)) ([41ee60d](41ee60d))

### Features

* add MoveNet and PoseNet notebooks for experiment ([916271e](916271e))
* add plot title for video seq ([db3d7c2](db3d7c2))
* add tflite model training and inference ([#33](#33)) ([3e7658c](3e7658c))
* add video samples to notebook ([702b334](702b334))
* fall detect pypi publishing ([#32](#32)) ([87f1751](87f1751))
* fall-detect initialization ([6e439aa](6e439aa)), closes [#14](#14)

### Performance Improvements

* [ImgBot] Optimize images ([#19](#19)) ([a489885](a489885))
@github-actions
Copy link

github-actions bot commented Oct 3, 2021

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivelin ivelin ivelin approved these changes

Assignees
No one assigned
Labels
released size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bhavikapanara @ivelin